Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.


Messages - Maddius

Pages: [1]
1
Thanks for the update, did any of the issues I raised in the 4.21 page get addressed?

See: https://forum.allegorithmic.com/index.php/topic,26732.0.html

2
There are some more missing includes when performing a non-unity build, it would be great if you could add the testing of clean rebuilds and non-unity testing to your build process.

Plugins/Runtime/Substance/Include/substance/source/iattachment.h
- #include "substance/source/typedefs.h" is missing

Plugins/Runtime/Substance/Include/substance/source/memory.h
- #include <assert.h> is missing

Plugins/Runtime/Substance/Include/substance/source/typedefs.h
#include "substance/source/memory.h" is missing

Plugins/Runtime/Substance/Source/SubstanceCore/Public/SubstanceCoreHelpers.h
- Due to #ifdef SUBSTANCE_FRAMEWORK_INCLUDED only being defined in the PCH any includes within that block are not correctly included

Plugins/Runtime/Substance/Source/SubstanceEditor/Classes/ReimportSubstanceImageInputFactory.h
- #include "EditorReimportHandler.h" is missing

Plugins/Runtime/Substance/Source/SubstanceEditor/Private/AssetTypeActions_SubstanceImageInput.h
- #include "SubstanceImageInput.h" is missing

Plugins/Runtime/Substance/Source/SubstanceEditor/Private/AssetTypeActions_SubstanceInstanceFactory.h
- These are all missing
#include "AssetTypeActions_Base.h"
#include "SubstanceInstanceFactory.h"

namespace SubstanceAir
{
   struct GraphDesc;
}

Plugins/Runtime/Substance/Source/SubstanceEditor/Private/AssetTypeActions_SubstanceTexture2D.h
- #include "Classes/SubstanceTexture2D.h" is missing

Plugins/Runtime/Substance/Source/SubstanceEditor/Private/SSubstanceEditorPanel.h
- #include "ISubstanceEditor.h" is missing

Plugins/Runtime/Substance/Source/SubstanceEditor/Private/SubstanceOptionWindow.cpp
- #include "Widgets/Layout/SSeparator.h" is missing

Plugins/Runtime/Substance/Source/SubstanceSource/Private/SubstanceToolkit.cpp
- #include "Colors/SColorBlock.h" is missing

Plugins/Runtime/Substance/Source/SubstanceSource/Private/SubstanceToolkit.h
- #include "substance/source/asset.h" is missing

3
Hey,

Thanks for the 4.21 release! This mostly works however, when building from source with clean intermediate files I am getting a number of compilation errors, it appears that these errors are related to missing include files, perhaps from the move to ICWYU mode?

See below for a list of files which are missing includes.

Runtime/Substance/Source/SubstanceCore/Private/SubstanceCallbacks.h
- #include "CoreMinimal.h" is missing for the TArray

Runtime/Substance/Source/SubstanceCore/Private/SubstanceCoreCustomVersion.cpp
- #include "Serialization/CustomVersion.h" is missing for the FCustomVersionRegistration

Runtime/Substance/Source/SubstanceCore/Private/SubstanceCoreCustomVersion.h
- #include "Misc/Guid.h" is missing for the FGuid

Runtime/Substance/Source/SubstanceCore/Private/SubstanceCoreHelpers.cpp
- SubstanceCorePrivatePCH.h and SubstanceCoreHelpers.h order needs to be swapped as a work around to the problems in SubstanceCoreHelpers.h
- #include "RenderUtils.h" is missing for the GPixel variable

Runtime/Substance/Source/SubstanceCore/Private/SubstanceGraphInstance.cpp
- #include "AssetToolsModule.h" is missing for the FAssetToolsModule reference

Runtime/Substance/Source/SubstanceCore/Private/SubstanceImageInput.cpp
- #include "HAL/FileManager.h" is missing for the IFileManager reference

Runtime/Substance/Source/SubstanceCore/Private/SubstanceStructuresSerialization.h
- #include "CoreMinimal.h" is missing for the FArchive reference

Runtime/Substance/Source/SubstanceCore/Private/SubstanceTexture2D.cpp
- #include "RenderUtils.h" is missing for the GPixel variable

Runtime/Substance/Source/SubstanceCore/Public/SubstanceCoreHelpers.h
- #include "CoreMinimal.h" is missing for the TMap reference (and others)
- #include "PixelFormat.h" is missing for the EPixelFormat reference
- class UMaterial; is missing as a forward declaration
- class UMaterialInstance; is missing as a forward declaration
- This header relies on SUBSTANCE_FRAMEWORK_INCLUDED being defined before its inclusion, this is currently only defined in the PCH, this means that the include order in SubstanceCoreHelpers.cpp cannot satisfy ICWYU requirements

Runtime/Substance/Source/SubstanceCore/SubstanceCore.Build.cs
- bEnforceIWYU needs to be disabled in order to work around the problem with SubstanceCoreHelpers.cpp

Cheers!

4
Thank you for releasing the new plugin! I mostly have this working but noticed one issue in the SubstanceSettings.cpp file which is that the variables are constructed in a different order to the order in which they are defined within the header which leads to a warning (Wreorder) on the Linux UE4 build. Obviously you can disable the warning but I assumed you would like to keep your code files as warning free as possible.

Hope that helps.

Cheers,

Tom

Pages: [1]